feat: improve filter options and add index filter#50
Merged
Conversation
Adds a filter to the index page to allow users to filter down the list of benchmarks. Also updates the benchmark page filter to only allow the user to select filters that result in actual data. This fixes a bug where for configs that are sparse, sometimes the user would select a filter that resulted in no data.
Collaborator
✅ Heimdall Review Status
|
patnir
approved these changes
May 6, 2025
Collaborator
|
Review Error for patnir @ 2025-05-06 20:44:00 UTC |
patnir
approved these changes
May 6, 2025
patnir
approved these changes
May 6, 2025
Collaborator
|
Review Error for patnir @ 2025-05-06 20:45:49 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a filter to the index page to allow users to
filter down the list of benchmarks.
Also updates the benchmark page filter to only allow the user to select filters that result in actual data. This fixes a bug where for configs that are sparse, sometimes the user would select a filter that resulted in no data.
Testing
Tested manually by changing filters.